Skip to content

chore(deps): roll up lumera devnet grpc bump - #217

Merged
a-ok123 merged 1 commit into
masterfrom
chore/devnet-grpc-rollup
Sep 10, 2026
Merged

chore(deps): roll up lumera devnet grpc bump#217
a-ok123 merged 1 commit into
masterfrom
chore/devnet-grpc-rollup

Conversation

@j-rafique

Copy link
Copy Markdown
Contributor

No description provided.

@j-rafique j-rafique self-assigned this Sep 9, 2026
@j-rafique
j-rafique force-pushed the chore/devnet-grpc-rollup branch 2 times, most recently from 7c1b85a to 93affac Compare September 9, 2026 17:34
@a-ok123
a-ok123 requested a lite review from Copilot September 9, 2026 20:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new govulncheck baseline script currently ignores govulncheck execution failures, which can cause false-negative CI passes.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the devnet Go module dependencies (notably google.golang.org/grpc) and tightens CI security scanning by introducing a govulncheck baseline wrapper that allows only explicitly reviewed, currently-unfixed reachable vulnerability IDs.

Changes:

  • Added scripts/govulncheck-baseline.sh and updated the govulncheck GitHub Action to use it.
  • Bumped devnet dependencies (grpc + assorted golang.org/x/*, OpenTelemetry, genproto) and updated the devnet go directive.
  • Made the consensus determinism workflow’s jq installation conditional.
File summaries
File Description
scripts/govulncheck-baseline.sh Adds a baseline allowlist wrapper that parses govulncheck JSON output and fails on new/actionable reachable vulnerabilities.
.github/workflows/govulncheck.yml Switches CI to use the new baseline wrapper script for actionable vulnerability gating.
devnet/go.mod Updates devnet module Go version and bumps grpc + related dependency versions.
devnet/go.sum Synchronizes go.sum with the devnet dependency bumps.
.github/workflows/consensus-determinism.yml Ensures jq is present without always running apt installs.
Review details
  • Files reviewed: 4/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/govulncheck-baseline.sh
@j-rafique
j-rafique force-pushed the chore/devnet-grpc-rollup branch from 93affac to 39aa994 Compare September 10, 2026 11:18
@j-rafique
j-rafique force-pushed the chore/devnet-grpc-rollup branch from 39aa994 to 2e4a9eb Compare September 10, 2026 11:50
@a-ok123
a-ok123 merged commit e40b6bc into master Sep 10, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants